<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6524#discussion_r2541737813">test/helpers/browse_tags_helper_test.rb</a>:</p>
<pre style='color:#555'>> + links = wikipedia_links("buried:wikipedia", "en:Westminster Abbey")
+ assert_equal 1, links.length
+ assert_equal "https://en.wikipedia.org/wiki/Westminster_Abbey?uselang=en", links[0][:url]
+ assert_equal "en:Westminster Abbey", links[0][:title]
</pre>
<p dir="auto">This is a bit silly, but I'd prefer it to be corrected. When it comes to the code, it doesn't matter as it's just a text match. However for nerds like me the lack of consistency creaks. If I read this, later I may have an incorrect understanding of what the tag means when editing the map.</p>
⬇️ Suggested change
<pre style="color: #555">- links = wikipedia_links("buried:wikipedia", "en:Westminster Abbey")
- assert_equal 1, links.length
- assert_equal "https://en.wikipedia.org/wiki/Westminster_Abbey?uselang=en", links[0][:url]
- assert_equal "en:Westminster Abbey", links[0][:title]
+ links = wikipedia_links("buried:wikipedia", "en:Stephen Hawking")
+ assert_equal 1, links.length
+ assert_equal "https://en.wikipedia.org/wiki/Stephen_Hawking?uselang=en", links[0][:url]
+ assert_equal "en:Stephen Hawking", links[0][:title]
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6524#pullrequestreview-3482365185">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOT4D2MJO65BIVU4QD35RMXRAVCNFSM6AAAAACL7TQLTWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIOBSGM3DKMJYGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNPN367T3DNCLOU3NL35RMXRA5CNFSM6AAAAACL7TQLTWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWPSCWQC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6524/review/3482365185</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6524#pullrequestreview-3482365185",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6524#pullrequestreview-3482365185",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>