<p dir="auto">Refs <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2806628769" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5539" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/5539/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/5539">#5539</a></p>
<p dir="auto">Although I've renamed the actions, I've left the urls alone for now. Further refactoring might include things like:</p>
<ul dir="auto">
<li>Reconsider whether the embedded html source, data download and image export functionality should all really be in the same controller</li>
<li>Make resourceful routes for whatever gets decided</li>
<li>Remove hardcoded form target urls from forms and use route helpers instead</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/6551'>https://github.com/openstreetmap/openstreetmap-website/pull/6551</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/commits/b6e024b3729d4688c950a350fc95eba056db7495" class="commit-link">b6e024b</a>  Rename export controller actions</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files">7 files</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files#diff-4f894049af3375c2bd4e608f546f8d4a0eed95464efcdea850993200db9fef5c">.rubocop.yml</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files#diff-debf59904131dc89a88ab44cbb1d6deaaa5a7d70c0507f674080df62f7c8e41f">app/abilities/ability.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files#diff-54679e47bd91d0e1b44dc9fd7224f5dff4645487fe07e15aa4a9671039a818cb">app/controllers/export_controller.rb</a>
    (12)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files#diff-fec0f9d24ec8e74969ee82b54520d2c639f73cf8782f342c5128417d26575374">app/views/export/show.html.erb</a>
    (0)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files#diff-db1600b3df800c073c8d2ff04b1f5042902abcb20b0a55729ddeca8d23012ea5">app/views/site/export.html.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5">config/routes.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551/files#diff-c5214c6ac7d239663aecd59e270a7be69caff34bb94d6dd1521e25c08eaa0a39">test/controllers/export_controller_test.rb</a>
    (26)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6551.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/6551.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6551.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/6551.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6551">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOHB7Z4WD5D7O2HUYD35X5KPAVCNFSM6AAAAACMXC6DKSVHI2DSMVQWIX3LMV43ASLTON2WKOZTGY2DQMZZGI3TSNY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLOHR3DK2UT5K7UY2335X5KPA5CNFSM6AAAAACMXC6DKSWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHNS5QOLU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6551</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6551",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6551",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>