<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6565#discussion_r2565201067">lib/id.rb</a>:</p>
<pre style='color:#555'>> @@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ID
-  LOCALES = Locale.list(Rails.root.join("vendor/assets/iD/iD/locales").entries.filter_map { |p| p.basename.to_s[/(.*)\.min\.json/] && Regexp.last_match(1) })
+  LOCALES = Locale.list(Rails.root.join("node_modules/@openstreetmap/id/dist/locales").entries.filter_map { |p| p.basename.to_s[/(.*)\.min\.json/] && Regexp.last_match(1) })
</pre>
<p dir="auto">I know this is just the same what was there before but, since we are at it, I think it's a good opportunity to refactor this a bit:</p>
⬇️ Suggested change
<pre style="color: #555">-  LOCALES = Locale.list(Rails.root.join("node_modules/@openstreetmap/id/dist/locales").entries.filter_map { |p| p.basename.to_s[/(.*)\.min\.json/] && Regexp.last_match(1) })
+  ID_PATH = Rails.root.join("node_modules/@openstreetmap/id")
+  LOCALES = Locale.list(Rails.root.join(ID_PATH, "dist/locales").entries.filter_map { |p| p.basename.to_s[/(.*)\.min\.json/] && Regexp.last_match(1) })
</pre>

<p dir="auto">I would go further than that, and perhaps will, but for the purposes of this PR I think this would be sufficient.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6565#pullrequestreview-3511205977">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJT7CMWLRRAAYD34LL36WZR5AVCNFSM6AAAAACNFFAIJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMJRGIYDKOJXG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLOYALO7E6RG2Q7PNL36WZR5A5CNFSM6AAAAACNFFAIJKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWRJDAFS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6565/review/3511205977</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6565#pullrequestreview-3511205977",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6565#pullrequestreview-3511205977",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>