<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<p dir="auto">As fast as I can tell the icon related changes seem fine though it would have been helpful to have a bit more information about what you were doing as the linked issue is only about the menu.</p>
<p dir="auto">The menu change does fix the current issues in dark mode, but the result has very little contrast between the background and the highlight, at least on this laptop, and the contrast in light mode is also reduced to the point where you can hardly see the bar.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6576#pullrequestreview-3531693881">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKM7K23MDJI3XCCWV337XOEXAVCNFSM6AAAAACNWYKF3CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMZRGY4TGOBYGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLZBEBCSQLDSKRWDGT37XOEXA5CNFSM6AAAAACNWYKF3CWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWSQFPTS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6576/review/3531693881</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6576#pullrequestreview-3531693881",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6576#pullrequestreview-3531693881",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>