<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/360803?s=20&v=4" /><strong>gravitystorm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6583#issuecomment-3607652886">(openstreetmap/openstreetmap-website#6583)</a></div>
<blockquote>
<p dir="auto">Looks good to me 👍 What are the edge cases?</p>
</blockquote>
<ul dir="auto">
<li>We use <code class="notranslate">·</code> in various places, but that's not in the erb_lint entity ignore list. See also <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2823676010" data-permission-text="Title is private" data-url="https://github.com/Shopify/erb_lint/issues/397" data-hovercard-type="pull_request" data-hovercard-url="/Shopify/erb_lint/pull/397/hovercard" href="https://github.com/Shopify/erb_lint/pull/397">Shopify/erb_lint#397</a></li>
<li>erb_lint gets confused when attempting to parse <a href="https://github.com/openstreetmap/openstreetmap-website/blob/acb1e73fa98e6cb7adf67f99e0be5891dcd4f6ea/app/views/browse/_relation.html.erb#L27-L35">https://github.com/openstreetmap/openstreetmap-website/blob/acb1e73fa98e6cb7adf67f99e0be5891dcd4f6ea/app/views/browse/_relation.html.erb#L27-L35</a> - it ends up thinking that <code class="notranslate">src=</code> is text content instead of an html attribute. It might be possible to refactor that to be more parser friendly (and maybe easier for me to read too!), or we just ignore that file.</li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6583#issuecomment-3607652886">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMFMEJDQHBZKNOHPZ3374EF7AVCNFSM6AAAAACN5BTUV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBXGY2TEOBYGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI7RC3U2UX5XPI25RT374EF7A5CNFSM6AAAAACN5BTUV2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWXBBVBM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6583/c3607652886</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6583#issuecomment-3607652886",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6583#issuecomment-3607652886",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>