<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/147741?s=20&v=4" /><strong>tomhughes</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6564#issuecomment-3612309734">(openstreetmap/openstreetmap-website#6564)</a></div>
<blockquote>
<p dir="auto">I also noticed that <a href="https://github.com/openstreetmap/openstreetmap-website/blob/6ca74538293c56da5309fdde0a2b956207126de2/app/controllers/users/heatmaps_controller.rb#L16"><code class="notranslate">HeatmapsController#show</code> checks for <code class="notranslate">@user</code> to be set</a>. If it's not set, then <code class="notranslate">@heatmap_data</code> won't be set and the view will fail anyway. From here, I think it makes sense to check for <code class="notranslate">@heatmap_data</code> in the view, as the controller does allow for the possibility of not setting it.</p>
</blockquote>
<p dir="auto">Or should the controller error if asked for a heatmap when there's no user?</p>
<p dir="auto">Note that <code class="notranslate">@user</code> there is derived from the arguments to the controller - it's not the logged in user. In fact there's no need to be logged in at all to call that URL so I'm not sure your theory about the missing session works?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6564#issuecomment-3612309734">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKFPIB7VZAWNNFYWHT4AA2KXAVCNFSM6AAAAACNE3XLA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJSGMYDSNZTGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOMEVQNPYML42D5NJL4AA2KXA5CNFSM6AAAAACNE3XLA6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWXJ54OM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6564/c3612309734</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6564#issuecomment-3612309734",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6564#issuecomment-3612309734",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>