<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2590052409">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>> end.html_safe
end
private
+ def expand_link_shorthands(text)
+ linkify_detection_rules = Array.wrap(Settings.linkify&.detection_rules)
+ linkify_detection_rules.each do |rule|
+ next unless rule.path_template && rule.patterns.is_a?(Array)
+
+ rule.patterns.each do |pattern|
+ expanded_path = "#{Settings.server_protocol}://#{rule.host || Settings.server_url}/#{rule.path_template}"
+ text.gsub!(Regexp.new("(?<before>\\s|^|>)#{pattern}(?<after>\\s|$|<)", Regexp::IGNORECASE), "\\k<before>#{expanded_path}\\k<after>")
+ end
+ end
+ [[Settings.linkify_hosts, Settings.linkify_hosts_replacement], [Settings.linkify_wiki_hosts, Settings.linkify_wiki_hosts_replacement]].each do |hosts, replacement|
+ text.gsub!(/(\s)#{Regexp.escape(replacement)}/, "\\1#{Settings.server_protocol}://#{hosts[0]}") if replacement && hosts&.any?
+ end
</pre>
<p dir="auto">Rinku only adds links to URLs with a protocol or the www subdomain: <a href="https://github.com/vmg/rinku?tab=readme-ov-file#rinku-is-a-standalone-library">https://github.com/vmg/rinku?tab=readme-ov-file#rinku-is-a-standalone-library</a></p>
<p dir="auto">However, the text representation of the shortened links doesn't have either. So when the plain text output gets run through it again, the osm.org link doesn't get recognized anymore.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2590052409">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKBDKZDCWWYQP3V5MD4ABY67AVCNFSM6AAAAACLXBWDSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNBRGM2DMNRZGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLK2TYMWI454HMBKBR34ABY67A5CNFSM6AAAAACLXBWDSCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWTCSUYG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6518/review/3541346691</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2590052409",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2590052409",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>