<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/147741?s=20&v=4" /><strong>tomhughes</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6588#issuecomment-3611101441">(openstreetmap/openstreetmap-website#6588)</a></div>
<p dir="auto">So the database healthcheck thing doesn't look unreasonable but I can't actually find any failing cases that look like they are caused by the database being ready so I'd be interested to know what made you think it was an issue?</p>
<p dir="auto">You've also extended the (recently introduced) timeout for the job from 20 minutes to 40 minutes - do you have some cases in mind where the current timeout was too short?</p>
<p dir="auto">Finally you've added a couple of retry loops with no real explanation of why you think they're a good idea - if <code class="notranslate">docker build</code> fails once why would think you think running it a second time would help? That suggests that transient failures of some sort are common - do you have an example of that? Ideally the solution to such things is to try and fix the transient failures not to work around them with a retry loop.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6588#issuecomment-3611101441">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKJXQHD763DF4IZH7L3775ZFAVCNFSM6AAAAACN7WGFGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJRGEYDCNBUGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOWKMDSF2QKXLZ5JSD3775ZFA5CNFSM6AAAAACN7WGFGCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWXHUEQC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6588/c3611101441</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6588#issuecomment-3611101441",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6588#issuecomment-3611101441",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>