<p></p>
<p><b>@pablobm</b> approved this pull request.</p>

<p dir="auto">Nitpick aside, I think this is good 👍 Thank you!</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6591#discussion_r2592521479">test/controllers/users/heatmaps_controller_test.rb</a>:</p>
<pre style='color:#555'>> +      assert_response :success
+      # The data should not be empty
+      heatmap_data = assigns(:heatmap_data)
+      assert_not_nil heatmap_data
+      assert_predicate heatmap_data[:data], :any?
+      # The data should be in the right format
+      heatmap_data[:data].each_value do |entry|
+        assert_equal [:date, :max_id, :total_changes], entry.keys.sort, "Heatmap data entries should have expected keys"
+      end
+      assert_equal 30, heatmap_data[:count]
+    end
+
+    def test_show_data_unknown_user
+      get user_heatmap_path(:user_display_name => "unknown_user")
+
+      # Should fail for deleted users
</pre>
⬇️ Suggested change
<pre style="color: #555">-      # Should fail for deleted users
+      # Should fail for unknown users
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6591#pullrequestreview-3544549942">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLMUHKCQCOC47QK3PD4AF24DAVCNFSM6AAAAACOB5M7BGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNBUGU2DSOJUGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLL3BGH5IT6PB4FZP534AF24DA5CNFSM6AAAAACOB5M7BGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWTIWFDM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6591/review/3544549942</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6591#pullrequestreview-3544549942",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6591#pullrequestreview-3544549942",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>