<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/36066?s=20&v=4" /><strong>pablobm</strong> created an issue <a href="https://github.com/openstreetmap/openstreetmap-website/issues/6592">(openstreetmap/openstreetmap-website#6592)</a></div>
<p dir="auto">It's common for PR reviewers to request that commits be squashed into a cleaner form, eliminating fixup commits and presenting a more consistent history. However this is not that clear in the contribution guidelines at <a href="https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md">CONTRIBUTING.md</a></p>
<p dir="auto">For example, the advice to «[a]void including "fixup" commits» only appears under a section about "large pull requests", failing to make it clear that is should apply to others.</p>
<p dir="auto">Also a pet peeve of mine: I would add advice for contributors not to work on <code class="notranslate">master</code> for their changes. Might as well include it in the guidelines too.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/6592">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKEGCEOX547K67INVD4AFWXPAVCNFSM6AAAAACOEUP6IKVHI2DSMVQWIX3LMV43ASLTON2WKOZTGY4TQNRXG44DEOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMCXJ2EOYLU2BKRGQD4AFWXPA5CNFSM6AAAAACOEUP6IKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHNY5KYIQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/6592</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/6592",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/6592",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>