<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2596269783">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>> +              Regexp.new("(?<before>^|#{URL_UNSAFE_CHARS})#{pattern}", Regexp::IGNORECASE),
+              "\\k<before>#{expanded_path}"
</pre>
<p dir="auto">I think you could use a lookbehind assertion here and then you wouldn't need to capture the prefix and add it back, like this:</p>
⬇️ Suggested change
<pre style="color: #555">-              Regexp.new("(?<before>^|#{URL_UNSAFE_CHARS})#{pattern}", Regexp::IGNORECASE),
-              "\\k<before>#{expanded_path}"
+              Regexp.new("(?<=^|#{URL_UNSAFE_CHARS})#{pattern}", Regexp::IGNORECASE),
+              expanded_path
</pre>


<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2596270792">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>> +          text.gsub(/(^|#{URL_UNSAFE_CHARS})\b#{Regexp.escape(replacement)}/) do
+            "#{Regexp.last_match(1)}#{Settings.server_protocol}://#{hosts[0]}"
</pre>
<p dir="auto">Another candidate for an assertion?</p>
⬇️ Suggested change
<pre style="color: #555">-          text.gsub(/(^|#{URL_UNSAFE_CHARS})\b#{Regexp.escape(replacement)}/) do
-            "#{Regexp.last_match(1)}#{Settings.server_protocol}://#{hosts[0]}"
+          text.gsub(/(?<=^|#{URL_UNSAFE_CHARS})\b#{Regexp.escape(replacement)}/) do
+            "#{Settings.server_protocol}://#{hosts[0]}"
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#pullrequestreview-3549249570">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMWNOWMFPCDXFSB54T4AQOLNAVCNFSM6AAAAACLXBWDSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNBZGI2DSNJXGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLL2UKXRMN4LOCGDF6L4AQOLNA5CNFSM6AAAAACLXBWDSCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWTRVACE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6518/review/3549249570</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6518#pullrequestreview-3549249570",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6518#pullrequestreview-3549249570",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>