<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6564#discussion_r2598280774">test/controllers/diary_entries_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -476,8 +476,11 @@ def test_index_paged
 
   def test_index_user_paged
     user = create(:user)
-    create_list(:diary_entry, 50, :user => user)
-    user.confirm!
+    num_entries = 50
+    build_list(:diary_entry, num_entries, :user => user) do |entry, i|
+      entry.created_at = (num_entries - i).days.ago
+      entry.save!
+    end
</pre>
<p dir="auto">Hm, there's a reason, but on second thought it was a bad idea.</p>
<p dir="auto">This is here because the test was failing once we allowed transitioning from <code class="notranslate">confirmed</code> to <code class="notranslate">suspended</code>. I didn't think it through and filed it under "issue with the test", but instead the test is showing why this can be a problem.</p>
<p dir="auto">I'll elaborate on the main thread so that it's more visible for future readers.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6564#discussion_r2598280774">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLSELNRR2Y6YTJFJV34AVPPFAVCNFSM6AAAAACNE3XLA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNJRGU4TAOBXHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNFNZWDGGMX7UAVQQT4AVPPFA5CNFSM6AAAAACNE3XLA6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWTWD456.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6564/review/3551590879</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6564#discussion_r2598280774",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6564#discussion_r2598280774",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>