<p></p>
<p><b>@prvshkmrin</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6599#discussion_r2600461658">app/assets/javascripts/language_selector.js</a>:</p>
<pre style='color:#555'>> @@ -12,3 +12,14 @@ $(document).on("click", "#select_language_dialog [data-language-code]", function
location.reload();
}
});
+
+// Prevent accidental Enter key submits inside the language dialog
+$(document).on("keydown", "#select_language_dialog", function (e) {
+ if (e.key === "Enter" || e.keyCode === 13) {
</pre>
<p dir="auto">Thanks for pointing that out — you're right, <code class="notranslate">keyCode</code> is deprecated and shouldn't be introduced here.</p>
<p dir="auto">I’ll update the PR to remove the <code class="notranslate">keyCode</code> check and switch to using <code class="notranslate">event.key</code>, which is the recommended modern approach.</p>
<p dir="auto">Thanks for the guidance!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6599#discussion_r2600461658">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLMZRTXXSMUC4BXEVD4AYBIRAVCNFSM6AAAAACONBGL3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNJUGQ4TCMRQGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJYN54TLMYCPQNMRJ34AYBIRA5CNFSM6AAAAACONBGL3SWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWT3U5UE.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6599/review/3554491202</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6599#discussion_r2600461658",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6599#discussion_r2600461658",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>