<p></p>
<p><b>@1ec5</b> commented on this pull request.</p>
<p dir="auto">These changes make the existing donation link redundant. The link in map attribution is already obscure, so removing it shouldn’t break anyone’s muscle memory too bad.</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/blob/7fdee463c76c1cbb07f9392986950674bc05edb8/config/layers.yml#L7-L10">https://github.com/openstreetmap/openstreetmap-website/blob/7fdee463c76c1cbb07f9392986950674bc05edb8/config/layers.yml#L7-L10</a></p>
<p dir="auto">Without any additional attribution string, the attribution code needs to be optional:</p>
<p dir="auto"><a href="https://github.com/openstreetmap/openstreetmap-website/blob/7fdee463c76c1cbb07f9392986950674bc05edb8/app/assets/javascripts/leaflet.map.js#L62-L64">https://github.com/openstreetmap/openstreetmap-website/blob/7fdee463c76c1cbb07f9392986950674bc05edb8/app/assets/javascripts/leaflet.map.js#L62-L64</a></p>
<blockquote>
<p dir="auto">Yay, another button in the navbar, and there's already a community thread asking for a link to community there as well..</p>
</blockquote>
<p dir="auto">There’s some discussion in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3610301699" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6517" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/6517/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/6517">#6517</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3682515719" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6575" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/6575/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/6575">#6575</a> about opportunities to consolidate existing navbar items so we don’t end up with a confusingly long list. Even if the navbar isn’t the perfect place for a donation link, it’s still a much better place than an attribution line that only sometimes appears on the map.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6600#discussion_r2600571819">app/views/layouts/_header.html.erb</a>:</p>
<pre style='color:#555'>> @@ -61,6 +61,9 @@
<li class="nav-item">
<%= link_to t("layouts.help"), help_path, :class => header_nav_link_class(help_path) %>
</li>
+ <li class="nav-item">
+ <%= link_to t("javascripts.map.make_a_donation"), donate_path, :class => header_nav_link_class(donate_path) %>
</pre>
<p dir="auto">The localizable string no longer has anything to do with map JavaScript, so we should replace it with one right next to the “Help” string in en.yml.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6600#discussion_r2600582970">app/views/site/donate.html.erb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,3 @@
+<% content_for :content do %>
+ <%= tag.iframe "", :frameBorder => 0, :id => "donate-embed", :class => "w-100 vh-100", :autofocus => true, :src => t("site.copyright.legal_babble.lead_2_making_donation_url") %>
</pre>
<p dir="auto">Should the donation page URL even be localizable? I think there’s only one version of the page, which should be hard-coded or moved to config/settings.yml and referenced through <code class="notranslate">Settings</code>.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6600#discussion_r2600628652">app/views/site/donate.html.erb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,3 @@
+<% content_for :content do %>
+ <%= tag.iframe "", :frameBorder => 0, :id => "donate-embed", :class => "w-100 vh-100", :autofocus => true, :src => t("site.copyright.legal_babble.lead_2_making_donation_url") %>
</pre>
<blockquote>
<p dir="auto">Seriously though if you want to propose a link to the donation site then just do that - framing the site is just going to be horrible.</p>
</blockquote>
<p dir="auto">The iframe is probably in response to the concern in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="781003154" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3041" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/3041/hovercard?comment_id=769873636&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/3041#issuecomment-769873636">#3041 (comment)</a> about taking the user away from the main site’s navigation, making it harder for the user to come back. On the other hand, the supporting site’s homepage isn’t optimized for being embedded in this site. There’s also at least one link to OSM that will cause this site to nest within itself.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6600#pullrequestreview-3554636919">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLISJAIWYXW4MD7D2BD4AYKHBAVCNFSM6AAAAACONMXAR6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNJUGYZTMOJRHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPAZPXEHYTAMF434BD4AYKHBA5CNFSM6AAAAACONMXAR6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWT352HO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6600/review/3554636919</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6600#pullrequestreview-3554636919",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6600#pullrequestreview-3554636919",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>