<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/360803?s=20&v=4" /><strong>gravitystorm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6600#issuecomment-3638068481">(openstreetmap/openstreetmap-website#6600)</a></div>
<p dir="auto">I'm reasonably happy with the idea of putting a donation link in the main navbar, but I'll make a more general comment about this over at <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3712975853" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6605" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/6605/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/6605">#6605</a></p>
<p dir="auto">It's a hard no from me on the iframe implementation though. It's really not a great user experience, it breaks bookmarks, leaves you unsure of which site you are adding payment information to, and so on. I would decline this PR on that basis alone.</p>
<p dir="auto">Perhaps you can consider having a page that introduces the topic of donations, and then the CTA takes you to support.openstreetmap.org - that might be better. It's worth considering that the target website is called "supporting" and not "donate", and it consists of multiple topics not just donations, when deciding what the link, url and content of the page here should be.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6600#issuecomment-3638068481">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMN743T4NXKEMCL22L4BBGP3AVCNFSM6AAAAACONMXAR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMZYGA3DQNBYGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMNVK67PG24MLDJ4IL4BBGP3A5CNFSM6AAAAACONMXAR6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWY3CCQC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6600/c3638068481</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6600#issuecomment-3638068481",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6600#issuecomment-3638068481",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>