<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<p dir="auto">Although there's a change of behaviour (enriching the <code class="notranslate">no_comment</code>), I'm ok with it. It simplifies the code and I think makes sense. Looking through the current translated strings, I don't see anything that would misfire there.</p>
<p dir="auto">If anything, I'd separate the refactor and the change of behaviour into separate commits, and add a test for <code class="notranslate">Changeset#comment</code> (and <code class="notranslate">#comment?</code>).</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6597#discussion_r2606050037">app/views/changesets/index.atom.builder</a>:</p>
<pre style='color:#555'>> @@ -25,7 +25,7 @@ atom_feed(:language => I18n.locale, :schema_date => 2009,
                  :type => "application/osmChange+xml"
 
       if !changeset.tags.empty? && changeset.tags.key?("comment")
</pre>
<p dir="auto">I think an additional API change would be good here, to completely abstract the comment living in a tag:</p>
⬇️ Suggested change
<pre style="color: #555">-      if !changeset.tags.empty? && changeset.tags.key?("comment")
+      if changeset.comment?
</pre>

<p dir="auto">What I'm not sure is why the empty check on <code class="notranslate">tags</code> was necessary 🤔</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6597#discussion_r2606058761">app/models/changeset.rb</a>:</p>
<pre style='color:#555'>> @@ -200,6 +200,8 @@ def save_with_tags!
     end
   end
 
+  def comment = tags["comment"].to_s.presence
</pre>
<p dir="auto">Is the <code class="notranslate">.to_s</code> required here? Just wondering, I'm not sure. If the value is nil, <code class="notranslate">#presence</code> will have the same behaviour, unless I'm much mistaken.</p>
<p dir="auto">I appreciate this is just copied from the existing code, but since we are improving this, we might as well consider this question.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6597#pullrequestreview-3561782805">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLL2TU4RPCFVCED5AD4A72DBAVCNFSM6AAAAACOL6GIKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNRRG44DEOBQGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOE3LGQXMU5G4CSCQD4A72DBA5CNFSM6AAAAACOL6GIKWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWUJR7BK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6597/review/3561782805</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6597#pullrequestreview-3561782805",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6597#pullrequestreview-3561782805",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>