<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/36066?s=20&v=4" /><strong>pablobm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6613#issuecomment-3666315395">(openstreetmap/openstreetmap-website#6613)</a></div>
<p dir="auto">I hoped the test would explain, but it didn't 😅 I went and had a look. I think I understand now:</p>
<ul dir="auto">
<li>Changeset tag values go through tag2link.</li>
<li>tag2link feeds from this list: <a href="https://github.com/JOSM/tag2link/blob/master/index.json">https://github.com/JOSM/tag2link/blob/master/index.json</a></li>
<li>Each separate tag in a <code class="notranslate">hashtags</code> key in a changeset gets applied this substitution rule:</li>
</ul>
<pre class="notranslate"><code class="notranslate">  {
    "key": "Key:hashtags",
    "url": "https://resultmaps.neis-one.org/osm-changesets?comment=$1",
    "source": "osmwiki:P8",
    "rank": "normal"
  },
</code></pre>
<ul dir="auto">
<li>That link expects the text to replace <code class="notranslate">$1</code> not to have a hashtag.</li>
<li>But we apply the substitution verbatim, passing the hashtag.</li>
<li>We need to remove the hashtag for that substitution to work, which is what you are doing here.</li>
</ul>
<p dir="auto">Your solution would fail if we had a similar tag2link rule that did expect the <code class="notranslate">#</code>, as it applies to all rules, not only <code class="notranslate">Key:hashtags</code>. Do we know of any such rule? I'm guessing the probability is low, as <code class="notranslate">#</code> has a special meaning in URLs as you say.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6613#issuecomment-3666315395">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOBSEHYMFO3WO3PE2L4CGETJAVCNFSM6AAAAACOW7N2LCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRWGMYTKMZZGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJGAJX42GH7TYRCCP34CGETJA5CNFSM6AAAAACOW7N2LCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTW2Q6EIG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6613/c3666315395</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6613#issuecomment-3666315395",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6613#issuecomment-3666315395",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>