<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/147277311?s=20&v=4" /><strong>aNsHuL5217</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6616#issuecomment-3677984616">(openstreetmap/openstreetmap-website#6616)</a></div>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/pnorman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/pnorman">@pnorman</a> I gave the <code class="notranslate">@"foo'</code> edge case a shot, but getting it to work safely (without breaking URLs or HTML) made the regex extremely complex and unreadable.</p>
<p dir="auto">I'm thinking of sticking with the simpler implementation. In my opinion, the trade-off of having hard-to-maintain code isn't worth it for such a rare edge case. The current version handles all standard and smart quotes correctly.</p>
<p dir="auto">I've reverted to the cleaner version—let me know if you're okay with this approach!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6616#issuecomment-3677984616">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLK2GVBZP7NRAPP7IDT4CWCUXAVCNFSM6AAAAACO75ADHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNZXHE4DINRRGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLEYFKSIDSMG4KASSL4CWCUXA5CNFSM6AAAAACO75ADHKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTW3HGLWQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6616/c3677984616</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6616#issuecomment-3677984616",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6616#issuecomment-3677984616",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>