<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/1231218?s=20&v=4" /><strong>1ec5</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/issues/6234#issuecomment-3678599033">(openstreetmap/openstreetmap-website#6234)</a></div>
<blockquote>
<p dir="auto">Or, we find a way to do the conversion to GeoJSON on the source</p>
</blockquote>
<p dir="auto">That would be elegant and probably improve performance, but I think this MapLibre conversion will already be large enough just trying to maintain compatibility with existing server-side functionality. Let’s split this out as a separate issue so we can investigate further without taking focus away from the essential steps.</p>
<blockquote>
<p dir="auto">It would, hover, require us to find a shared way to define how what lines we consider an area. I see that osm2geojson-ultra does this <a href="https://github.com/dschep/osm2geojson-ultra/blob/main/src/polytags.json">in a static file</a>. iD and OSMCha use a different approach, AFAIK both <a href="https://github.com/ideditor/id-area-keys">https://github.com/ideditor/id-area-keys</a> which is not updated ATM. Maybe we should try to revitalize this projects?</p>
</blockquote>
<p dir="auto">I don’t think this needs to be perfect right out of the gate. osm2geojson-ultra’s file already manages to be more comprehensive than <a href="https://github.com/openstreetmap/leaflet-osm/blob/9af3c9e86a3723b02b4cfdfc3283246e6494713d/leaflet-osm.js#L92">leaflet-osm’s hard-coded list of area keys</a>. Any improvements from <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3239427696" data-permission-text="Title is private" data-url="https://github.com/dschep/osm2geojson-ultra/issues/8" data-hovercard-type="issue" data-hovercard-url="/dschep/osm2geojson-ultra/issues/8/hovercard" href="https://github.com/dschep/osm2geojson-ultra/issues/8">dschep/osm2geojson-ultra#8</a> would be transparent to osm-website, even if it means a transitive dependency on id-area-keys.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/6234#issuecomment-3678599033">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKZQARZZPQSXBUKVU34CZMCFAVCNFSM6AAAAACCGOXFYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNZYGU4TSMBTGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMZTPGMYHZ7RDXSFX34CZMCFA5CNFSM6AAAAACCGOXFYSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTW3IL3XS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/6234/3678599033</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/6234#issuecomment-3678599033",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/6234#issuecomment-3678599033",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>