<p><b>@pnorman</b> commented on this pull request.</p>

<p><g-emoji alias="fireworks" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f386.png" ios-version="6.0">🎆</g-emoji></p><hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/668#pullrequestreview-15223574">middle-pgsql.cpp</a>:</p>
<pre style='color:#555'>> @@ -378,8 +367,9 @@ size_t middle_pgsql_t::local_nodes_get_list(nodelist_t &out, osmium::WayNodeList
     size_t wrtidx = 0;
     for (size_t i = 0; i < nds.size(); ++i) {
         if (std::isnan(out[i].lat)) {
-            std::unordered_map<osmid_t, osmNode>::iterator found = pg_nodes.find(nds[i].ref());
-            if(found != pg_nodes.end()) {
+            std::unordered_map<osmid_t, osmNode>::iterator found =
+                pg_nodes.find(nds[i].ref());
+            if (found != pg_nodes.end()) {
</pre>
<p>could this entire loop be an <code>auto nd:nds</code>?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/668#pullrequestreview-15223574">node-ram-cache.cpp</a>:</p>
<pre style='color:#555'>>      }
 
-    return 1;
+    if (coord.valid()) {
+        nodesCacheHits++;
+    }
+    nodesCacheLookups++;
+
+    return coord;
 }
</pre>
<p>If any reformatting has been missed by only doing the diffs, I'd just as soon reformat the entire file. Of course, you might have already thought of this ;)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/668#pullrequestreview-15223574">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AD2-7rkBftCG3_Pu-sXEhKk7pSg6FQdoks5rPDFHgaJpZM4LbKgQ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AD2-7oYPRxaesJD0FhhxmmYQzY4wWJJvks5rPDFHgaJpZM4LbKgQ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/osm2pgsql/pull/668#pullrequestreview-15223574"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/osm2pgsql","title":"openstreetmap/osm2pgsql","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/osm2pgsql"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pnorman commented on #668"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/osm2pgsql/pull/668#pullrequestreview-15223574"}}}</script>