<p>This PR works, but I'm not sure if it's ready to be merged or not. Travis passes with it because it only checks the NoDB tests where we don't have any sanitizer reported leaks. We have leaks in other tests. Merging this would help stop regressions in anything covered by the NoDB tests but also require that the other leaks are cleaned up before enabling more tests.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/728#issuecomment-294010636">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AD2-7qbUgV8Js7UpsOwcKqzpuJ9QIigvks5rvoMAgaJpZM4MpCs3">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AD2-7gDASLLrKjW8_BPsgbQ92Cs_QwbUks5rvoMAgaJpZM4MpCs3.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/osm2pgsql/pull/728#issuecomment-294010636"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/osm2pgsql","title":"openstreetmap/osm2pgsql","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/osm2pgsql"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pnorman in #728: This PR works, but I'm not sure if it's ready to be merged or not. Travis passes with it because it only checks the NoDB tests where we don't have any sanitizer reported leaks. We have leaks in other tests. Merging this would help stop regressions in anything covered by the NoDB tests but also require that the other leaks are cleaned up before enabling more tests."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/osm2pgsql/pull/728#issuecomment-294010636"}}}</script>