<p><b>@StyXman</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/813#discussion_r162039972">osmdata.cpp</a>:</p>
<pre style='color:#555'>> @@ -390,20 +390,22 @@ void osmdata_t::stop() {
// should be the same for all outputs
const bool append = outs[0]->get_options()->append;
- //threaded pending processing
- pending_threaded_processor ptp(mid, outs, outs[0]->get_options()->num_procs,
- append);
-
- if (!outs.empty()) {
- //This stage takes ways which were processed earlier, but might be
- //involved in a multipolygon relation. They could also be ways that
- //were modified in diff processing.
- mid->iterate_ways( ptp );
-
- //This is like pending ways, except there aren't pending relations
- //on import, only on update.
- //TODO: Can we skip this on import?
- mid->iterate_relations( ptp );
+ {
</pre>
<p>I would add a comment about why this block; at least for me, coming from Python, it's slightly strange. Otherwise, I would make the secondary effects more explicit.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/813#pullrequestreview-89426825">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AD2-7qjsDVPwIFY68E_BtHyvrciz1nlHks5tLetEgaJpZM4RdYHk">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AD2-7jd2YVmNf-8xBRZcUE4FlBncwMJ5ks5tLetEgaJpZM4RdYHk.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/osm2pgsql/pull/813#pullrequestreview-89426825"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/osm2pgsql","title":"openstreetmap/osm2pgsql","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/osm2pgsql"}},"updates":{"snippets":[{"icon":"PERSON","message":"@StyXman commented on #813"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/osm2pgsql/pull/813#pullrequestreview-89426825"}}}</script>