<p>I have tested the codebase with</p>
<ul>
<li>gcc 8.1.0 + <code>CXXFLAGS="-pedantic -Werror -fsanitize=address"</code><br>
and I have received this interesting warning :</li>
</ul>
<pre lang="log"><code>[ 14%] Building CXX object CMakeFiles/osm2pgsql_lib.dir/node-ram-cache.cpp.o
[ 15%] Building CXX object CMakeFiles/osm2pgsql_lib.dir/options.cpp.o
[ 16%] Building CXX object CMakeFiles/osm2pgsql_lib.dir/osmdata.cpp.o
[ 17%] Building CXX object CMakeFiles/osm2pgsql_lib.dir/osmium-builder.cpp.o
/openstreetmap/osm2pgsql/osmium-builder.cpp: In member function 'geom::osmium_builder_t::wkbs_t geom::osmium_builder_t::create_polygons(const osmium::Area&)':
/openstreetmap/osm2pgsql/osmium-builder.cpp:404:22: error: catching polymorphic type 'class osmium::geometry_error' by value [-Werror=catch-value=]
} catch (osmium::geometry_error) { /* ignored */
^~~~~~~~~~~~~~
[ 18%] Building CXX object CMakeFiles/osm2pgsql_lib.dir/output-gazetteer.cpp.o
cc1plus: all warnings being treated as errors
CMakeFiles/osm2pgsql_lib.dir/build.make:302: recipe for target 'CMakeFiles/osm2pgsql_lib.dir/osmium-builder.cpp.o' failed
</code></pre>
<p>other important:</p>
<ul>
<li>tested with <code>gcc:8</code> official docker image ( <a href="https://hub.docker.com/r/library/gcc/tags/" rel="nofollow">https://hub.docker.com/r/library/gcc/tags/</a> )</li>
<li>full travis log: <a href="https://travis-ci.org/ImreSamu/osm2pgsql/jobs/388050138" rel="nofollow">https://travis-ci.org/ImreSamu/osm2pgsql/jobs/388050138</a></li>
<li>my experimental travis code -> : <a href="https://github.com/ImreSamu/osm2pgsql/tree/travis_gcc_45678">https://github.com/ImreSamu/osm2pgsql/tree/travis_gcc_45678</a></li>
<li>job passed with : <code>gcc:7</code> , <code>gcc:6</code>, <code>gcc:5</code> , <code>gcc:4</code> <g-emoji class="g-emoji" alias="+1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/issues/850">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AD2-7gAkZ4HIj6TlKc8AyJEkpDqRqRPEks5t5mF8gaJpZM4UalUm">mute the thread</a>.<img src="https://github.com/notifications/beacon/AD2-7oaYOeEBxosLJr1XI4Nk61cwBXv6ks5t5mF8gaJpZM4UalUm.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/openstreetmap/osm2pgsql/issues/850","url":"https://github.com/openstreetmap/osm2pgsql/issues/850","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/osm2pgsql","title":"openstreetmap/osm2pgsql","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/osm2pgsql"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"gcc 8.1 - warning (#850)"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/osm2pgsql/issues/850"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "gcc 8.1 - warning (#850)",
"sections": [
{
"text": "",
"activityTitle": "**ImreSamu**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ImreSamu",
"facts": [
{
"name": "Repository: ",
"value": "openstreetmap/osm2pgsql"
},
{
"name": "Issue #: ",
"value": 850
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/osm2pgsql\",\n\"issueId\": 850,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"openstreetmap/osm2pgsql\",\n\"issueId\": 850\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/osm2pgsql/issues/850"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 342512934\n}"
}
],
"themeColor": "26292E"
}</script>