<p>Also adds a test for parsing with extra-attributes enabled.</p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #849.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="320809421" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/osm2pgsql/issues/849" href="https://github.com/openstreetmap/osm2pgsql/issues/849">#849</a>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/osm2pgsql/pull/860'>https://github.com/openstreetmap/osm2pgsql/pull/860</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>always fully parse objects when extra attributes are requested</li>
  <li>add test for parsing with extra arguments</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-0">osmdata.cpp</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-1">osmdata.hpp</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-2">tests/CMakeLists.txt</a>
    (1)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-3">tests/test-parse-extra-args.cpp</a>
    (114)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/osm2pgsql/pull/860.patch'>https://github.com/openstreetmap/osm2pgsql/pull/860.patch</a></li>
  <li><a href='https://github.com/openstreetmap/osm2pgsql/pull/860.diff'>https://github.com/openstreetmap/osm2pgsql/pull/860.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/860">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AD2-7kaJwWvWYEHJWv8RQJUkK0n-ApZaks5uNsL-gaJpZM4VvUM5">mute the thread</a>.<img src="https://github.com/notifications/beacon/AD2-7iTtKyY9iXbuutvC09keBiAEZVKSks5uNsL-gaJpZM4VvUM5.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/osm2pgsql","title":"openstreetmap/osm2pgsql","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/osm2pgsql"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Always fully parse objects when extra attributes are requested (#860)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/osm2pgsql/pull/860"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/860",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/860",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Always fully parse objects when extra attributes are requested (#860)",
"sections": [
{
"text": "",
"activityTitle": "**Sarah Hoffmann**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@lonvia",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "9172f95",
"value": "always fully parse objects when extra attributes are requested"
},
{
"name": "7f9239f",
"value": "add test for parsing with extra arguments"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[osmdata.cpp](https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-0) (9 changes)"
},
{
"name": "Modified",
"value": "[osmdata.hpp](https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-1) (1 changes)"
},
{
"name": "Modified",
"value": "[tests/CMakeLists.txt](https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-2) (1 changes)"
},
{
"name": "Added",
"value": "[tests/test-parse-extra-args.cpp](https://github.com/openstreetmap/osm2pgsql/pull/860/files#diff-3) (114 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/osm2pgsql\",\n\"issueId\": 860,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/osm2pgsql\",\n\"pullRequestId\": 860\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/osm2pgsql/pull/860"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/osm2pgsql/pull/860.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/osm2pgsql/pull/860.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 364725049\n}"
}
],
"themeColor": "26292E"
}
]</script>