<p>Hey <a class="user-mention" data-hovercard-user-id="1447941" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/lonvia">@lonvia</a>, I did not run clang-format in the first place because it causes a lot of space diffs on the file, so I didn't want to commit these all. Maybe I applied it wrongly?</p>
<p>Also, <code>git-clang-format</code> (<code>clang-format</code> actually because I could not find the former) is not fixing variables name. I don't know if it's supposed to, but I fixed it manually.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/865#issuecomment-421804716">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AD2-7uHxCv3oe0w5SFCO20GSEIfkaJY-ks5ubpFLgaJpZM4WQdAP">mute the thread</a>.<img src="https://github.com/notifications/beacon/AD2-7iDa65dqlmR2IHJj-3W0lFyGq-0-ks5ubpFLgaJpZM4WQdAP.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/osm2pgsql","title":"openstreetmap/osm2pgsql","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/osm2pgsql"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bagage in #865: Hey @lonvia, I did not run clang-format in the first place because it causes a lot of space diffs on the file, so I didn't want to commit these all. Maybe I applied it wrongly? \r\n\r\nAlso, `git-clang-format` (`clang-format` actually because I could not find the former) is not fixing variables name. I don't know if it's supposed to, but I fixed it manually."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/osm2pgsql/pull/865#issuecomment-421804716"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/865#issuecomment-421804716",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/865#issuecomment-421804716",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/osm2pgsql] Display progress while processing pending relations/ways (#865)",
"sections": [
{
"text": "",
"activityTitle": "**Gautier Pelloux-Prayer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@bagage",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/osm2pgsql\",\n\"issueId\": 865,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/osm2pgsql\",\n\"pullRequestId\": 865\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/osm2pgsql/pull/865#issuecomment-421804716"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 373411855\n}"
}
],
"themeColor": "26292E"
}
]</script>