<p><b>@lonvia</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1004#discussion_r350954053">src/table.cpp</a>:</p>
<pre style='color:#555'>>                  "    WHERE ST_IsValid(way)\n"
                 "    ORDER BY "
                 "ST_GeoHash(ST_Transform(ST_Envelope(way),4326),10)\n"
                 "    COLLATE \"C\"",
                 m_target->name, m_table_space);
             m_sql_conn->exec("RESET client_min_messages");
         }
-        m_sql_conn->exec("DROP TABLE %1%", m_target->name);
-        m_sql_conn->exec("ALTER TABLE %1%_tmp RENAME TO %1%", m_target->name);
+        m_sql_conn->exec("DROP TABLE {}", m_target->name);
+        m_sql_conn->exec("ALTER TABLE {}_tmp RENAME TO {}", m_target->name);
</pre>
<p>second parameter missing</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1004#discussion_r350954385">src/table.cpp</a>:</p>
<pre style='color:#555'>> @@ -207,17 +202,17 @@ void table_t::stop(bool updateable, bool enable_hstore_index,
                in OSM. */
             m_sql_conn->exec("SET client_min_messages = WARNING");
             m_sql_conn->exec(
-                "CREATE TABLE %1%_tmp %2% AS\n"
-                "  SELECT * FROM %1%\n"
+                "CREATE TABLE {}_tmp {} AS\n"
+                "  SELECT * FROM {}\n"
</pre>
<p>parameter missing</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1004#discussion_r350954873">src/table.cpp</a>:</p>
<pre style='color:#555'>>                                   "    FOR EACH ROW EXECUTE PROCEDURE "
-                                 "%1%_osm2pgsql_valid();",
+                                 "{}_osm2pgsql_valid();",
</pre>
<p>parameter missing</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1004#discussion_r350957118">tests/test-db-copy-mgr.cpp</a>:</p>
<pre style='color:#555'>> @@ -182,9 +182,9 @@ TEST_CASE("db_copy_mgr_t")
 
         auto c = db.connect();
 
-        auto sql = boost::format("SELECT h->'%1%' from test_copy_mgr");
+        std::string const sql{"SELECT h->'{}' FROM test_copy_mgr"};
</pre>
<p>char const *?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1004?email_source=notifications&email_token=AA6353UHI4PJ7SUDLEECPIDQVV7NJA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNCGPVI#pullrequestreview-323250133">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353XWM4MPMTHK67YBHP3QVV7NJANCNFSM4JRNZ45A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353QCHCGGTEFLZB2HWIDQVV7NJA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNCGPVI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1004?email_source=notifications\u0026email_token=AA6353UHI4PJ7SUDLEECPIDQVV7NJA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNCGPVI#pullrequestreview-323250133",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1004?email_source=notifications\u0026email_token=AA6353UHI4PJ7SUDLEECPIDQVV7NJA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNCGPVI#pullrequestreview-323250133",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>