<p><b>@lonvia</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1004#discussion_r351937252">src/table.cpp</a>:</p>
<pre style='color:#555'>>              }
             for (size_t i = 0; i < hstore_columns.size(); ++i) {
-                m_sql_conn->exec("CREATE INDEX ON %1% USING GIN (\"%3%\") %4%",
-                                 m_target->name, i, hstore_columns[i],
-                                 (table_space_index
-                                      ? "TABLESPACE " + table_space_index.get()
-                                      : ""));
+                m_sql_conn->exec(
+                    "CREATE INDEX ON {} USING GIN (\"{}\") {}"_format(
+                        m_target->name, i, hstore_columns[i],
</pre>
<p>'i' needs to be removed. There is no %2% in the original anymore. I'm mildly surprised that the tests didn't catch that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1004?email_source=notifications&email_token=AA6353QTXERURQQDH3K7SHLQWBBYPA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNLQEIQ#pullrequestreview-324469282">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353REKFIX6QJBDONTOMLQWBBYPANCNFSM4JRNZ45A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353RVKGBRJY7I6RRH2MTQWBBYPA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNLQEIQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1004?email_source=notifications\u0026email_token=AA6353QTXERURQQDH3K7SHLQWBBYPA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNLQEIQ#pullrequestreview-324469282",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1004?email_source=notifications\u0026email_token=AA6353QTXERURQQDH3K7SHLQWBBYPA5CNFSM4JRNZ45KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNLQEIQ#pullrequestreview-324469282",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>