<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1153#discussion_r419673895">src/lua-utils.cpp</a>:</p>
<pre style='color:#555'>> @@ -158,11 +159,16 @@ static int pcall_error_traceback_handler(lua_State *lua_state)
// wrapper function for lua_pcall to include a stack traceback
int luaX_pcall(lua_State *lua_state, int narg, int nres)
{
+// Lua 5.1 doesn't support luaL_traceback, unless LuaJIT is used
+#if LUA_VERSION_NUM < 502 && HAVE_LUAJIT == 0
</pre>
<p>I think I would change this to <code>#if LUA_VERSION_NUM < 502 && !defined(HAVE_LUAJIT)</code></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1153#discussion_r419673895">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353WDBAHNTYFUJXLLCO3RP4JLFANCNFSM4MY6WRRQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353SZZY4VKSS5I4NOO23RP4JLFA5CNFSM4MY6WRR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODAUBVDA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1153#discussion_r419673895",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1153#discussion_r419673895",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>