<p>These changes contain various cleanups of the flex tests. This is mostly about</p>
<ul>
<li>giving tests a consistent structure to make them easier to read</li>
<li>making them independent of another by using independent configs for each test</li>
<li>only testing one type of thing per test and removing some duplication</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/osm2pgsql/pull/1239'>https://github.com/openstreetmap/osm2pgsql/pull/1239</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Cleanup flex-area test: Use minimal config file for this test</li>
<li>Clean flex-attr tests</li>
<li>Extend bbox test to mercator projection</li>
<li>Cleanup and extend flex invalid geometry test</li>
<li>Cleanup tests checking Lua failures are caught</li>
<li>Cleanup test checking updates of tables without geometry</li>
<li>Cleanup tablespace test</li>
<li>Cleanup and simplify uni test</li>
<li>Cleanup flex validgeom test</li>
<li>Cleanup flex type conversion tests</li>
<li>Cleanup flex update tests</li>
<li>Cleanup flex extra tests</li>
<li>Cleanup basic flex tests</li>
<li>Rename flex-extra test to flex-stage2</li>
<li>Move all area size checks from base tests into flex-area tests</li>
<li>Add tests for linestring geometry (with and without split)</li>
<li>Cleanup base tests</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-3dea97423f83302e647a3bab62bf1157">tests/CMakeLists.txt</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-f9abeb0fd057383551e98d11ce445bc3">tests/data/test_output_flex.lua</a>
(57)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-0359c8dd6893a46a23b9e1401b13960d">tests/data/test_output_flex_area.lua</a>
(33)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-64ca2aa6c521c8ead102bf71ec5dec63">tests/data/test_output_flex_attr.lua</a>
(10)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-8cdb7582cf139680d4780525c081f112">tests/data/test_output_flex_fail.lua</a>
(36)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-ff4f0dcb2488d41a0b278427a616ec0b">tests/data/test_output_flex_invalid_geom.lua</a>
(45)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-2d87b970d00d42087b0e0760ff225bb3">tests/data/test_output_flex_line.lua</a>
(24)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-23c537ec3f1eeedded2a9db4bb365803">tests/data/test_output_flex_lua_fail.lua</a>
(18)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-cb460cabb499fca795312aff252352af">tests/data/test_output_flex_stage2.lua</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-3a8a7ff106a033dd63075a59ed7f3524">tests/data/test_output_flex_types.lua</a>
(94)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-109eef5b350f1c9f7a94991814507e95">tests/data/test_output_flex_uni.lua</a>
(84)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-6d45f6caaad6875163b3e361eb95a466">tests/test-output-flex-area.cpp</a>
(49)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-d6ed99c76dd1df0b956ba29aadaecb9f">tests/test-output-flex-attr.cpp</a>
(116)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-0b43c216880ba2f0443c7fcfa0533d3c">tests/test-output-flex-bbox.cpp</a>
(35)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-cfa6c35318bd4dfc647a1f3bb1f0e4b4">tests/test-output-flex-invalid-geom.cpp</a>
(66)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-f34aa435046f49d1bc5ba452580e826a">tests/test-output-flex-line.cpp</a>
(37)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-2e241bc6f60acd0b646eae8749b14922">tests/test-output-flex-lua-fail.cpp</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-153ac0f5c4982f24fe30f4ce28aaf1fb">tests/test-output-flex-nogeom.cpp</a>
(14)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-bc1d1d63c12717ce18c871da9452b919">tests/test-output-flex-stage2.cpp</a>
(150)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-39549042f55108ccccebae27ba316409">tests/test-output-flex-tablespace.cpp</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-a11c6107e31c9fe6d76d284e15f5d21a">tests/test-output-flex-types.cpp</a>
(60)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-16f8925cd2baa6cbfb7ce5d6764efdca">tests/test-output-flex-uni.cpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-ca3795e98d6427fb8181dc08f0e87ae6">tests/test-output-flex-update.cpp</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-6f12c7238e89933eee1e050f6cb7b0a4">tests/test-output-flex-validgeom.cpp</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1239/files#diff-95af6bbef6e9262868a5f2a04b96cf5a">tests/test-output-flex.cpp</a>
(140)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/osm2pgsql/pull/1239.patch'>https://github.com/openstreetmap/osm2pgsql/pull/1239.patch</a></li>
<li><a href='https://github.com/openstreetmap/osm2pgsql/pull/1239.diff'>https://github.com/openstreetmap/osm2pgsql/pull/1239.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1239">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353XDOLE7VJVALQKWIZ3RZM7UVANCNFSM4ONOQU7A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353TZTSOMZCATAJPYXBDRZM7UVA5CNFSM4ONOQU7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JVPFGGA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1239",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1239",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>