<p></p>
<p><b>@lonvia</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1249#discussion_r454161968">tests/test-output-flex-way-relation-add.cpp</a>:</p>
<pre style='color:#555'>> +    "w15 v1 dV Tt=ag Nn17,n19",
+    "r30 v1 dV Tt=ag Mw10@,w11@,w12@mark,w13@,w14@mark"};
+
+// adding relation (marked), also check case where relation changed to contain
+// the way under test
+
+TEST_CASE("test way: add relation with way in t1 (marked)")
+{
+    options_t options = testing::opt_t().slim().flex(conf_file);
+
+    testing::data_t data{tdata};
+
+    data.add("w10 v1 dV Tt1=yes,t2=yes Nn10,n11");
+
+    SECTION("no relation") {}
+    SECTION("relation without w10") { data.add("r32 v1 dV Tt=ag Mw15@"); }
</pre>
<p>We are missing the indirect dependencies through members here. r32 should have the other ways as members, when it gets changed. This should then cover the last error case we have seen (the one that resulted in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="650670878" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/osm2pgsql/issues/1244" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/osm2pgsql/pull/1244/hovercard" href="https://github.com/openstreetmap/osm2pgsql/pull/1244">#1244</a>). Unfortunately that means that we need separate functions. :(</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1249#pullrequestreview-447860027">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353UCEH7JUMPB4HAE4BTR3QDERANCNFSM4OUWA7LA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353VAKZDS4YWFZMCVI3DR3QDERA5CNFSM4OUWA7LKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODKY42OY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1249#pullrequestreview-447860027",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1249#pullrequestreview-447860027",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>