<p></p>
<p><b>@pnorman</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1251#discussion_r455312885">src/input-handler.cpp</a>:</p>
<pre style='color:#555'>> @@ -9,8 +9,23 @@ input_handler_t::input_handler_t(osmium::Box const &bbox, bool append,
 : m_data(osmdata), m_bbox(bbox), m_append(append)
 {}
 
+void input_handler_t::negative_id_warning()
+{
+    fmt::print(stderr,
+               "\nWARNING: The input file contains at least one object with "
+               "a negative id.\n         Negative ids are not properly "
+               "supported in osm2pgsql (and never\n         were). They will "
+               "not work in future versions at all. You can use\n"
+               "         the osmium tool to 'renumber' your file.\n\n");
</pre>
<p>Can we reformat this text? If necessary, the max line length can be overridden for this part of the file.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1251#pullrequestreview-449293663">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353TQRIYAGBF6ZLY7ONLR3YENNANCNFSM4O2ZCQZQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353UUV6ANXUL4GH5PKT3R3YENNA5CNFSM4O2ZCQZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODLD22XY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1251#pullrequestreview-449293663",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1251#pullrequestreview-449293663",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>