<p></p>
<p><b>@pnorman</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1281#discussion_r499749199">src/options.cpp</a>:</p>
<pre style='color:#555'>>  std::string database_options_t::conninfo() const
 {
+    if (compare_prefix(db, "postgresql://") ||
+        compare_prefix(db, "postgres://")) {
+        return db;
+    }
+
     std::string out{"fallback_application_name='osm2pgsql'"};
</pre>
<p>Should this be above the block for <code>postgresql://</code> handling? We still want to set the fallback application name</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/1281#discussion_r499750430">src/options.cpp</a>:</p>
<pre style='color:#555'>>      std::string out{"fallback_application_name='osm2pgsql'"};
 
+    if (std::strchr(db.c_str(), '=') != nullptr) {
</pre>
<p>Would this cause problems with properly escaped DB names containing a =?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1281#pullrequestreview-502258130">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353QQ4I42CXHAHHZHDFTSJH5FZANCNFSM4SEVEPAA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353UUFIGCYEWCUIGJ2PTSJH5FZA5CNFSM4SEVEPAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODXX5TUQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1281#pullrequestreview-502258130",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1281#pullrequestreview-502258130",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>