<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cquest/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cquest">@cquest</a> Can you elaborate on what you tested exactly and how the numbers changed with and without this patch? There are several issues here that could affect timing: With the patch fewer ways (and relations) will be marked as (possibly) changed. On the other hand we have to lookup the old location of all nodes, which is cheap if we are using flat node store, but possibly expensive when using the database. All of this, of course, depends on what kind of node changes there are usually.</p>
<p>To figure out the best way to do this we need some numbers not from isolated queries, but from real-world update runs. Does this, on avarage, speed up things considerably or not? How does the flat node factor in here? How does the <a href="https://github.com/openstreetmap/osm2pgsql/blob/master/docs/bucket-index.md">bucket index</a>? <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cquest/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cquest">@cquest</a> You speek of a 10% speed up which would be well worth it, but I am not sure what you have been measuring there.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/issues/1046#issuecomment-712658434">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353QK2LIP3VTFQQ6E3RLSLU5BRANCNFSM4KCMNW2Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AA6353XBRKEF4XWRPVQELADSLU5BRA5CNFSM4KCMNW22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFJ5E4AQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/issues/1046#issuecomment-712658434",
"url": "https://github.com/openstreetmap/osm2pgsql/issues/1046#issuecomment-712658434",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>