<p dir="auto"><code>std::strerror()</code> is not thread-safe, so it is best avoided. Also the output of the error messages will be more uniform this way.</p>
<p dir="auto">There is one other case where we use <code>strerror()</code> (in <a href="https://github.com/openstreetmap/osm2pgsql/blob/master/src/expire-tiles.cpp#L44">expire-tiles.cpp</a>) but that's only a warning, so we can't replace it by <code>system_error</code>, although maybe it shouldn't be a warning? Leaving that for later, the expire code needs some work anyway.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/osm2pgsql/pull/1634'>https://github.com/openstreetmap/osm2pgsql/pull/1634</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/osm2pgsql/pull/1634/commits/de32d6a5843d9c7f5c16ae15314281a62507b5dc" class="commit-link">de32d6a</a> Use std::system_error instead of runtime_error/strerror</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/osm2pgsql/pull/1634/files">2 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1634/files#diff-a8eea9738eb1b17b373a490a1543ce42400ca81da9f3a943a059a4a3c377a705">src/node-persistent-cache.cpp</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/osm2pgsql/pull/1634/files#diff-ebe8a6dda90254ae93bff2dd2b6b4ccaa5421a1f78a2fc291dc7cd1969d00f07">src/taginfo.cpp</a>
(11)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/osm2pgsql/pull/1634.patch'>https://github.com/openstreetmap/osm2pgsql/pull/1634.patch</a></li>
<li><a href='https://github.com/openstreetmap/osm2pgsql/pull/1634.diff'>https://github.com/openstreetmap/osm2pgsql/pull/1634.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1634">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353QFRJ67CBUOYCEUL4TUZEUPNANCNFSM5NMABB3Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AA6353QTC7YVE7PCYURKWW3UZEUPNA5CNFSM5NMABB32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4QW67GCQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/osm2pgsql/pull/1634</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1634",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1634",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>