<p></p>
<blockquote>
<p dir="auto">I needed tests/bdd/steps/<strong>pycache</strong> in .gitignore. The tests/<strong>pycache</strong> can be removed I think.</p>
</blockquote>
<p dir="auto">Done.</p>
<blockquote>
<p dir="auto">The test/bdd directory contains the tests themselves (flex, parameters, regression) as well as the "infrastructure" (environment.py, steps) which I find slightly confusing.</p>
</blockquote>
<p dir="auto">The directory layout is prescribed by behave. We could change some of it but I don't know what side-effects that has. I'd rather go with the standard here.</p>
<blockquote>
<p dir="auto">Also parameters is very general, maybe command-line or so?</p>
</blockquote>
<p dir="auto">Done</p>
<blockquote>
<p dir="auto">There are several tests with a single input node that is just there so that some data is imported, it isn't checked what. Does it make sense to special case this somehow?</p>
</blockquote>
<p dir="auto">I've looked into this and it is not really random data that gets imported. In <code class="notranslate">command-line/dsn.feature</code> and <code class="notranslate">command-line/schema.feature</code> exactly one data point is expected, so 'Given some OSM data<code class="notranslate">would not specific enough.. That leaves only</code>command-line/invalid.feature`. In the end it's probably better to have the actual data as a remainder in the feature file. By writing it into the 'Background' section, the repetition can be kept to a minimum.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/1670#issuecomment-1122107868">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353RD2DPLQW5J2S3FRFDVJIO47ANCNFSM5UI3RVMA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AA6353TFDGUWA3P6SHOHGE3VJIO47A5CNFSM5UI3RVMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOILRADXA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/osm2pgsql/pull/1670/c1122107868</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/1670#issuecomment-1122107868",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/1670#issuecomment-1122107868",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>