<p></p>
<p><b>@mboeringa</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/osm2pgsql/pull/2019#discussion_r1278400645">flex-config/geometries.lua</a>:</p>
<pre style='color:#555'>>      { column = 'area', type = 'real' },
+    -- In this column we'll put the true area calculated on the spheroid
</pre>
<blockquote>
<p dir="auto">on the spheroid</p>
</blockquote>
<p dir="auto">Shouldn't this read 'on the sphere'?</p>
<p dir="auto">By the way, I recommend you to thoroughly test this, also with data near the date line. I ran into serious issues with crashes with Planet wide (generalized) data and PostGIS ST_Area and spherical calculations when I first attempted implementing both spherical and spheroidal area calculations, and had to switch to spheroidal (ST_Area(geography,true)) to overcome these issues. ST_Area for some reason failed with spherical calculations.</p>
<p dir="auto">I have never been able to track down the real cause, and simply worked around it with the (slower) spheroidal calculations, but if this solution for osm2pgsql relies on some of the same libraries as PostGIS, it may encounter similar issues if it hasn't been fixed in the mean time.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/osm2pgsql/pull/2019#pullrequestreview-1553424618">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353TYPBNKAMVJAF2AVMLXSVW6ZANCNFSM6AAAAAA24PWRM4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AA6353RK5ZQLZE5BMSQ3ZNLXSVW6ZA5CNFSM6AAAAAA24PWRM6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTS4S5QOU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/osm2pgsql/pull/2019/review/1553424618</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/osm2pgsql/pull/2019#pullrequestreview-1553424618",
"url": "https://github.com/openstreetmap/osm2pgsql/pull/2019#pullrequestreview-1553424618",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>