<ul dir="auto">
<li><code class="notranslate">includes/config.h.in</code>
<ul dir="auto">
<li>Wrap contents in <code class="notranslate">#ifndef CONFIG_H</code></li>
</ul>
</li>
<li><code class="notranslate">includes/mod_tile.h</code>
<ul dir="auto">
<li>Include <code class="notranslate">protocol.h</code>
<ul dir="auto">
<li>For <code class="notranslate">XMLCONFIG_MAX</code></li>
</ul>
</li>
<li>Include <code class="notranslate">apr_tables.h</code>
<ul dir="auto">
<li>For <code class="notranslate">apr_time_t</code>/<code class="notranslate">apr_uint64_t</code></li>
</ul>
</li>
<li>Include <code class="notranslate">netinet/in.h</code>
<ul dir="auto">
<li>For <code class="notranslate">in6_addr</code>/<code class="notranslate">in_addr_t</code></li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/cache_expire.c</code>
<ul dir="auto">
<li>Include <code class="notranslate">netinet/in.h</code>
<ul dir="auto">
<li>For <code class="notranslate">htonl</code>/<code class="notranslate">htons</code></li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/gen_tile.cpp</code>
<ul dir="auto">
<li>Use <code class="notranslate">snprintf</code> instead of <code class="notranslate">sprintf</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: 'sprintf' is deprecated</code> in <a href="https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579"><code class="notranslate">macOS</code> builds</a></li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/gen_tile_test.cpp</code>
<ul dir="auto">
<li>Use <code class="notranslate">snprintf</code> instead of <code class="notranslate">sprintf</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: 'sprintf' is deprecated</code> in <a href="https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579"><code class="notranslate">macOS</code> builds</a></li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/mod_tile.c</code>
<ul dir="auto">
<li>Use <code class="notranslate">snprintf</code> instead of <code class="notranslate">sprintf</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: 'sprintf' is deprecated</code> in <a href="https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579"><code class="notranslate">macOS</code> builds</a></li>
</ul>
</li>
<li>Cast <code class="notranslate">os_thread</code> to <code class="notranslate">(unsigned long)</code> in <code class="notranslate">ap_log_rerror</code> calls format
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: format specifies type 'long' but the argument has type 'apr_os_thread_t'</code></li>
<li><code class="notranslate">os_thread</code> is an alias of <code class="notranslate">unsigned long</code></li>
</ul>
</li>
<li>Use <code class="notranslate">"%" APR_OFF_T_FMT</code>/<code class="notranslate">APR_UINT64_T_FMT "..."</code> to resolve warnings under <code class="notranslate">macOS</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: format specifies type 'long' but the argument has type 'off_t'</code>
<ul dir="auto">
<li>The format/type for <code class="notranslate">apr_off_t</code> varies under <code class="notranslate">macOS</code></li>
</ul>
</li>
<li>And resolve <code class="notranslate">warning: format specifies type 'long' but the argument has type 'apr_uint64_t'</code>
<ul dir="auto">
<li>The format/type for <code class="notranslate">apr_uint64_t</code> varies under <code class="notranslate">macOS</code></li>
</ul>
</li>
</ul>
</li>
<li>Divide by <code class="notranslate">2.0</code> rather than <code class="notranslate">2</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">possible loss of precision</code> warning</li>
</ul>
</li>
<li>Use <code class="notranslate">%li</code> rather than <code class="notranslate">"%" APR_TIME_T_FMT</code> as format for <code class="notranslate">maxAge</code>
<ul dir="auto">
<li>It is defined as a <code class="notranslate">long int</code></li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/render_submit_queue.c</code>
<ul dir="auto">
<li>Include <code class="notranslate">string.h</code>/<code class="notranslate">strings.h</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: call to undeclared library function 'bzero'</code></li>
<li>To resolve <code class="notranslate">warning: call to undeclared library function 'strncpy'</code></li>
<li>To resolve <code class="notranslate">warning: call to undeclared library function 'strdup'</code></li>
<li>To resolve <code class="notranslate">warning: call to undeclared library function 'strerror'</code></li>
<li>To resolve <code class="notranslate">warning: call to undeclared library function 'strchr'</code></li>
<li>To resolve <code class="notranslate">warning: call to undeclared library function 'strlen'</code></li>
<li>To resolve <code class="notranslate">warning: call to undeclared library function 'memset'</code></li>
</ul>
</li>
<li>Cast <code class="notranslate">performance_stats.stat[i].noRendered</code> to <code class="notranslate">(float)</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">possible loss of precision</code> warning</li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/renderd.c</code>
<ul dir="auto">
<li>Use <code class="notranslate">snprintf</code> instead of <code class="notranslate">sprintf</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: 'sprintf' is deprecated</code> in <a href="https://github.com/openstreetmap/mod_tile/actions/runs/7590268635/job/20677236621#step:5:579"><code class="notranslate">macOS</code> builds</a></li>
</ul>
</li>
<li>Change <code class="notranslate">const char</code> to <code class="notranslate">char</code> for <code class="notranslate">ini_fileExtension</code>, <code class="notranslate">ini_mimeType</code>, <code class="notranslate">ini_outputFormat</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: format specifies type 'char *' but the argument has type 'const char *'</code></li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/request_queue.c</code>
<ul dir="auto">
<li>Add <code class="notranslate">default case</code> to <code class="notranslate">switch</code> statements
<ul dir="auto">
<li>To resolve:
<ul dir="auto">
<li><code class="notranslate">warning: enumeration values 'queueRender' and 'queueDuplicate' not handled in switch</code></li>
<li><code class="notranslate">warning: enumeration values 'cmdIgnore', 'cmdDone', and 'cmdNotDone' not handled in switch</code></li>
</ul>
</li>
</ul>
</li>
</ul>
</li>
<li><code class="notranslate">src/store_file.c</code>
<ul dir="auto">
<li>Cast <code class="notranslate">pthread_self()</code> to <code class="notranslate">(unsigned long)</code>
<ul dir="auto">
<li>To resolve <code class="notranslate">warning: format specifies type 'unsigned long' but the argument has type 'pthread_t'</code></li>
</ul>
</li>
</ul>
</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/mod_tile/pull/376'>https://github.com/openstreetmap/mod_tile/pull/376</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/aa9a0f16dd002d358643b835080e3b1c0563a65f" class="commit-link">aa9a0f1</a> Wrap config.h contents</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/462243af8f4182475e1565ccdb54f9e5683537bf" class="commit-link">462243a</a> Cast `pthread_self()` to `unsigned long`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/8616d55d3d6c47ba75c2328adb6ce2c1d008e8ed" class="commit-link">8616d55</a> Cast `os_thread` to `unsigned long`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/8ccbe2c8c83d0810dc54ce1c1478ab65ec01202d" class="commit-link">8ccbe2c</a> Include `string.h`/`strings.h` to resolve `undeclared library function`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/cd909fe90c706eaacc55f556320067dc02c6a35b" class="commit-link">cd909fe</a> Include `netinet/in.h` for `htons`/`htonl`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/c22c951120191232a782d254baaf291e5a28a86c" class="commit-link">c22c951</a> Include `netinet/in.h` for `in6_addr`/`in_addr_t`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/8d1cb191c2e2fad4587c4896db1c70b11090b54b" class="commit-link">8d1cb19</a> Include `protocol.h` for `XMLCONFIG_MAX`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/6591a98392e3ada067dab10e3b3861b6efb26fd2" class="commit-link">6591a98</a> Include `apr_tables.h` for `apr_*`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/791bf13b508be04db0ebce530ad47b0f5e015c88" class="commit-link">791bf13</a> Resolve `warning: format specifies type 'char *' but the argument has type 'const char *'`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/7bec18aead5e05a34f5622821c9043c384aabee1" class="commit-link">7bec18a</a> Resolve `warning: enumeration values ... not handled in switch`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/4178822dd1b300fadd02bf780db62a78e1e6a0f9" class="commit-link">4178822</a> Resolve `warning: format specifies type 'long' but the argument has type 'apr_uint64_t'`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/1d86b3f8fd135752c0ab900882b39b4616e54518" class="commit-link">1d86b3f</a> Resolve `warning: format specifies type 'long long' but the argument has type 'long'`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/d80966a95a7311f0c7722f72c7569df3278945ff" class="commit-link">d80966a</a> Resolve `warning: format specifies type 'long' but the argument has type 'off_t'`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/9bce220d97c1c0e208c739a492a819741f7b8fc9" class="commit-link">9bce220</a> Resolve `warning: 'sprintf' is deprecated`</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/e4e708c3fdc59c3d7e5a7cb2262f4f80b387c711" class="commit-link">e4e708c</a> Resolve loss of precision</li>
<li><a href="https://github.com/openstreetmap/mod_tile/pull/376/commits/c3316f35183489f55f1949f130773073e64064f6" class="commit-link">c3316f3</a> Don't need `-Wno-implicit-function-declaration`</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/mod_tile/pull/376/files">11 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-bc668a2c9f2299cef15b222055b4b4d5311646caec2e7610e540cee18ae9b948">.github/workflows/build-and-test.yml</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-9859b4133ec3cdbf4203e8865213b99570605882c7b10dd487d44de03da30459">includes/config.h.in</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-6eca8792c9294524ac1447e2e555db30a9434b40bb792364e0f0f1d7b98f764c">includes/mod_tile.h</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-8cb37b13a79db4104046d1946b4dede71bd02cda33ce870765bd50d06b44f9ab">src/cache_expire.c</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-24d2c9f48fad0996b30ba3cf92de842990379883baaffb424a9248d0f1f064e4">src/gen_tile.cpp</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-67291fd78142bc5be82477cd39cc6d7777f0ed62a0b6bfed47bee2c9b8f2c798">src/gen_tile_test.cpp</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-531f2ce0748b97527d6baf14e5c0dec0db585fbf1bf9eec14511a34eaf797575">src/mod_tile.c</a>
(92)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-b3e4a2a669e5da7f2783c10ad61b80987dec211cbdfa2bd36163a728cc461f23">src/render_submit_queue.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-3f59a73c820d2e95c60403cfca31fe5de38a3de58bbd2968b4b04d62f107805f">src/renderd.c</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-fefc89b9fa537b917f6e7029ee36799c3c4766af2be1f5580bb15010254c379d">src/request_queue.c</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/mod_tile/pull/376/files#diff-5820f717ee3e6a581e8fc9f42cc34aefea2987793e76ed479f0589bcd84d6322">src/store_file.c</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/mod_tile/pull/376.patch'>https://github.com/openstreetmap/mod_tile/pull/376.patch</a></li>
<li><a href='https://github.com/openstreetmap/mod_tile/pull/376.diff'>https://github.com/openstreetmap/mod_tile/pull/376.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/mod_tile/pull/376">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353VY6OKRKKSS2W7XP33YPNCQXAVCNFSM6AAAAABCC4CP5GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TCOBYGY3DIOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AA6353T7QI32UQHEYIJZPMDYPNCQXA5CNFSM6AAAAABCC4CP5GWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHZL5IHA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/mod_tile/pull/376</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/mod_tile/pull/376",
"url": "https://github.com/openstreetmap/mod_tile/pull/376",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>