<p></p>
<p><b>@lonvia</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2135#discussion_r1484030582">src/command-line-parser.cpp</a>:</p>
<pre style='color:#555'>>  
-    if (!options.slim) {
-        options.middle_database_format = 0;
+        options.middle_database_format = middle_database_format;
+    } else if (options.slim) {
+        // For append mode we keep old default for backwards compatibility,
+        // for create mode the new format is the default.
+        // Will be overwritten by properties setting if it exists.
+        options.middle_database_format = options.append ? 1 : 2;
</pre>
<p dir="auto">Shouldn't the append case remain '0' for 'please determine from the database'?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2135#pullrequestreview-1871913753">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353UJY3FCB7YH6CATJZLYSXPTZAVCNFSM6AAAAABC7NGYBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZRHEYTGNZVGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AA6353VE2FQWNY4XGE3YSG3YSXPTZA5CNFSM6AAAAABC7NGYBKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTPSMRRS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><osm2pgsql-dev/osm2pgsql/pull/2135/review/1871913753</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/osm2pgsql-dev/osm2pgsql/pull/2135#pullrequestreview-1871913753",
"url": "https://github.com/osm2pgsql-dev/osm2pgsql/pull/2135#pullrequestreview-1871913753",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>