<p dir="auto">Various small cleanups of issues found by clang-tidy 18. See individual commits.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251'>https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/commits/57073c18ecbfdbcefd2030dbb197d0426c8f7264" class="commit-link">57073c1</a> clang-tidy cleanup: remove redundant member inits</li>
<li><a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/commits/91011cdba71ab9511f8b966e5d1e87121b19cc55" class="commit-link">91011cd</a> clang-tidy: Put function definitions in cpp file where they belong</li>
<li><a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/commits/30a5cd2137a7a5363b19fa226767701a90f53e80" class="commit-link">30a5cd2</a> Use smallest usable type (uint8_t) for some enums</li>
<li><a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/commits/48299dabc9f84ed430306d44ec2e613632077c1c" class="commit-link">48299da</a> Use const ref instead of string copy</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files">12 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-7b13f906ba10da2d5e72528b2ef0ace0242412eebfa4d4c77d612c7cc964f04a">src/expire-config.hpp</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-3eae076e672de2c081bf15f0d826d9cfb5415af741a5e24bc8294798aa02a8dc">src/flex-table.hpp</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-1518590f5c5028e6a34dd695918cfc679e97e1452dc0dc814718f250d93795de">src/input.cpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-35f5644f7fe1eb80c4529d5e53d5f40a5ee3db7809be036fd24ffa9bef61930a">src/input.hpp</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-46882d1e2c375c88c0c6a14b122da94ffd1ec567929ed25afef31cb4b6ebd794">src/logging.hpp</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-ce4cd3a98af004a409e0aec2d79813d02005b6e18d226c8e2bd7bbbd10733628">src/middle.cpp</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-701e90286007c8f36e7825136161bdcc828cd93654be765f06416d40dc43b80a">src/middle.hpp</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-a4c050acb925a30a662c7f8c4ba06da77f99c236f74c04b91b74a453e84d7747">src/options.hpp</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-785c8da946a79954c6089076f7bf9a585dc6822f989220fa918499e415dd5e46">src/output-flex.hpp</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-33f6f98ac38892c5010da188eedbbf64d4647116b43cfcf22a6522d2195dc5de">src/properties.cpp</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-409bf9b04336636af7e951123603d529e84cf35f6eaf6bb14258d5d7c8e39788">src/properties.hpp</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251/files#diff-ccb82b1f38060edf8112a411d7cfba14fb0b4af4ebd8d86a889538149566ccbf">src/thread-pool.hpp</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251.patch'>https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251.patch</a></li>
<li><a href='https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251.diff'>https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AA6353RF3KSLU4KFHX4PBGDZW75NVAVCNFSM6AAAAABOLDPJIOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTANRZGYYTGOA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AA6353UCXWVLOAA6LX5GSL3ZW75NVA5CNFSM6AAAAABOLDPJIOWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJNV23ZI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><osm2pgsql-dev/osm2pgsql/pull/2251</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251",
"url": "https://github.com/osm2pgsql-dev/osm2pgsql/pull/2251",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>