[OSM-dev] Using NULL values in mapnik / postgres DB

[Jon Burgess]

On Sat, 2007-02-24 at 13:16 +0000, Jon Burgess wrote:
> On Sat, 2007-02-24 at 08:55 +0000, Artem Pavlenko wrote:
> > I had a go:) . Changes in svn.  Latest osm2pgsql requires geos (I'm using 
> > latest trunk http://svn.refractions.net/geos/trunk). 
> > 
> > TODO: 
> > 1. output wkb(hex) instead of wkt
> > 2. build polygons with holes.
> > 3. investigate why geos fails to clean 4067050 and 4229618
> > 
> > Cheers,
> > Artem
> 
> I've rendered a few local areas after using this osm2pgsql version and
> i'm seeing gaps in some of the ways which I don't think existed before.
> Have you seen anything like this?
> 
> I'm going to investigate the osm and sql for these ways.
> 
> 	Jon
> 

I committed a fix for the problem I was seeing, the bug was causing some
valid segments to be dropped:

--- build_geometry.cpp  (revision 2158)
+++ build_geometry.cpp  (working copy)
@@ -90,7 +90,7 @@

    while (pos != end)
    {
-      if (pos->x0 != pos->x1 && pos->y0 != pos->y1)
+      if (pos->x0 != pos->x1 || pos->y0 != pos->y1)
       {


Jon