[OSM-dev] Invalid XML?

[Florian Lohoff]

On Thu, Sep 11, 2008 at 03:58:22AM +0200, Stefan de Konink wrote:
> Subject: Re: [OSM-dev] Invalid XML?
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Karl Newman schreef:
> > On Wed, Sep 10, 2008 at 6:08 PM, Stefan de Konink <skinkie at xs4all.nl
> > <mailto:skinkie at xs4all.nl>> wrote:
> > 
> >     -----BEGIN PGP SIGNED MESSAGE-----
> >     Hash: SHA1
> > 
> >     http://api.openstreetmap.org/api/0.5/node/169532897
> > 
> > 
> >     Looking at the last tag... that looks pretty wrong to me. And don't go
> >     fixing the tag... if the database outputs this, it is pretty b0rked.
> > 
> > 
> > 
> >     Stefan
> > 
> > 
> > So everyone can see what you're talking about:
> > 
> > <osm version="0.5" generator="OpenStreetMap server">
> > <node id="169532897" lat="50.9521054" lon="4.3022661" user="Polyglot"
> > visible="true" timestamp="2007-12-14T22:53:31+00:00">
> > <tag k="created_by" v="JOSM"/>
> > <tag k="highway" v="bus_stop"/>
> > <tag k="name" v="Driesstraat\"/>
> > </node>
> > </osm>
> > 
> > Are you concerned about the backslash in the name? I'm not an XML expert
> > but I don't think that's a problem because it's inside a quoted
> > attribute value. At least Firefox and my XML-aware text editor don't
> > complain about it.
> 
> #xml is mentionted that this is indeed valid too... and I need to
> implement an escaping sequence myself to prevent the quoting in the
> target, that does respect \ chars. (I thought it was invalid because
> some other XML page mentioned to use \\)
> 
> Since this clearly looks like a typo (trying to hit enter) one my ask if
> a client should check for this...

A couple of days back i started a thread about this kind of problems.

Its not that the xml is broken afterwards but people could start putting
bad things into the database by closing a tag and reopening a new one.

Its the database/api which needs to refuse to put something like this
into the database.

Flo
-- 
Florian Lohoff                  flo at rfc822.org             +49-171-2280134
	Those who would give up a little freedom to get a little 
          security shall soon have neither - Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.openstreetmap.org/pipermail/dev/attachments/20080911/a074024c/attachment.pgp>