[OSM-dev] TaskRegistrar.patch

[Brett Henderson]

Thanks Marcus, I've checked your latest patch into the jpf-plugin branch 
and now merged it back across to trunk so in theory osmosis now has 
decent plugin support!  I say in theory because I don't have any plugins 
to test it with :-)

Do you have a sample plugin that could be used as an example?  Ideally 
the wiki should be updated to describe how plugins work.

I haven't merged your changes to entity classes yet.  They're one part 
of osmosis that I'm fairly particular about and I don't want to add 
methods without making them consistent across the board.  Part of this 
is deciding once and for all whether entity classes should be immutable 
or not.  Your changes are still available on the jpf-plugin branch 
though so aren't lost.

As for the code, I haven't made many functional changes, mainly 
formatting updates to match existing conventions.
* I've made the plugin manager non-static which seems to work (I hope I 
haven't broken anything).
* I've updated some argument names to match existing conventions 
(removal of 'a' prefixes on method arguments is one, I don't understand 
what the purpose of them is).
* Removed final keyword from method arguments.  Again, just a convention 
thing because I haven't done it elsewhere.
* I've made logging more consistent so that it doesn't clutter the 
console.  I've set JPF logging levels to WARNING, may need to be revisited.
* All errors in plugins now make osmosis abort.  This matches existing 
behaviour in other areas of osmosis.  If a plugin is broken it will have 
to be removed.

Cheers,
Brett

Marcus Wolschon wrote:
> see attached file.
>