[OSM-dev] osmosis + postgis 2.0 - usage of legacy function namens

[Brett Henderson]

On Sat, Jul 9, 2011 at 4:48 AM, Florian Lohoff <f at zz.de> wrote:

> On Fri, Jul 08, 2011 at 09:34:35AM -0500, Ian Dees wrote:
> > On Fri, Jul 8, 2011 at 9:12 AM, Florian Lohoff <f at zz.de> wrote:
> >
> > >
> > > Hi,
> > > i just found a future bug when postgis 2.0 will be used more - osmosis
> 0.39
> > > uses legacy functions e.h. MakeLine which should be replaces with
> > > ST_MakeLine
> >
> > Where are you getting postgis 2.0 from? Is it packaged anywhere?
> >
> > Is ST_MakeLine backwards compatible?
>
> I took the debian postgis 1.5.x package and a svn checkout of postgis
> 2.0 and copied over the debian directory. Change version strings in
> the changelog and removed the patches from the debian/patches dir
> and it built smooth.
>
> All non ST_ functions are deprecated and will only be available when
> you import the postgis-legacy.sql so its better to switch now using
> the ST_ standard functions. MakeLine and ST_MakeLine are actually the same
> function as i read it.
>
> I found it in the 2.0 TRUNK NEWS file:
> http://svn.osgeo.org/postgis/trunk/NEWS
>
>  - #722, #302 Most deprecated functions removed (over 250 functions)
>    (Regina Obe / Paragon Corporation, Paul Ramsey / OpenGeo)
>    (most deprecated in 1.2) removed non-ST variants buffer,
>    length, intersects (and internal functions renamed) etc.
>    If you have been using these - CHANGE your apps or suffer the
> consequences.
>    If you don't see a function documented -- it ain't supported.
>    Some constraints in older tables were built with deprecated functions.
>    If you restore you may need to rebuild these
>    with populate_geometry_columns().
>
> postgis 2.0 is interesting for me because of ST_ConcaveHull i am using.
>

Hi Flo,

Thanks for the info.  I replaced all occurences of MakeLine with
ST_MakeLine.  It's checked in and passing all unit tests.
http://dev.openstreetmap.de:23457/hudson/job/osmosis-SNAPSHOT-ant/229/

Let me know if you see any issues.

Brett
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/dev/attachments/20110722/f6273003/attachment.html>