[OSM-dev] Osm2pgsql and failed planet import

[Martijn van O]

On 30 August 2011 20:47, Frederik Ramm <frederik at remote.org> wrote:
> I guess this needs some thorough investigation and I always hoped that
> someone more familar with that part of the code (hint, hint) would find the
> time to have a look ;)

I guess it would be helpful if someone with this error could actually
look in the tables and see how many ways are pending (is it all of
them?). I guess it has to be ways, because I can't imagine there being
enough relations to cause this problem.

In any case, I had a look at the code and there aren't many ways that
a way can be marked pending. However, a way can be marked pending on
insert (I can't remember de rationale for that). That happens when the
fourth argument for pgsql_ways_set is true, which is on the condition
(!filter && polygon) and polygon is set in the pgsql_filter_tags
function.

That code has a comment about that it used to stop early but doesn't
any more. As far as I can see the FLAG_POLYGON is now always set to
true which means every way is marked pending on insert. Which would
cause the symptoms describes. So:

1. Looks like the restructuring of pgsql_filter_tags missed a case.
Not sure what the problem was with the way it was.

2. I don't recall the reason for marking polygons as pending. Does anybody else?

Have a nice day,
-- 
Martijn van Oosterhout <kleptog at gmail.com> http://svana.org/kleptog/