[OSM-dev] Feedback for Vespucci-dev

[Jan Schejbal]

Hi,
sorry for not communicating here earlier, I was pretty busy and needed a
break.

It is awesome how active Vespucci development has become after the GSoC
- thanks for all the great work! Especiall the new tag editor design is
great!


I tried the new version, and one think I didn't like was the context
menu. While I understand it is necessary in some situations, in some
cases it makes editing nodes twice as difficult. Instead of two taps on
the node to open the tag editor, sometimes four taps are required now
(node, context menu to select, then again node, context menu to edit).

Should I try to add a preference directly to the overflow menu (for
quick access) that allows to toggle the behavior (i.e. disable the
context menu)?

I will also try to make the context menu ordered by distance from the click.


I think have found a few regressions, but I do not want to "fix" them
without discussion in case they were intentional:

1) Undo had different backgrould colors for undo and redo items to make
it easy to distinguish them. This got probably lost in r336.

2) The tag editor autocomplete rows had a reduced height to make it
easier to read the list. This got probably also lost in r336.

3) The "avoid duplicate tag names in autosuggest" change in r303 results
in a strictly alphabetic tag name list, instead of offering the most
relevant tags first. Should we maybe use a LinkedHashSet instead of
TreeSet? This would ensure duplicates are not shown, but "interesting"
tags still appear first. This is especially useful to suggest optional
tags from presets while the field is completely empty.

I would be happy if someone with more Android UI experience could take
care of 1 and 2, because I did it in some way that seemed to work, and
it probably wasn't very good ;-)

Kind regards,
Jan