[OSM-dev] Osmupdate 0.4.5 fails (osmctools)

Florian Lohoff f at zz.de
Mon Feb 22 18:46:11 UTC 2021

On Mon, Feb 22, 2021 at 11:36:13AM +0100, Sebastiaan Couwenberg wrote:
> On 2/22/21 10:47 AM, Florian Lohoff wrote:
> > Could be please ban all people not using a VCS,
> > not distributing a Makefile, and using "C Obfuscator"
> > to Elba or something.
> osm-c-tools is hosted on GitLab:
>  https://gitlab.com/osm-c-tools/osmctools
> Can you create a merge re

So why is the osm wiki Dokumentation then pointing into
a completely different direction?


"Download and build in one run:   wget -O - http://m.m.i24.cc/osmupdate.c | cc -x c - -o osmupdate"

And the fix is not at all sufficient. Currently osmupdate
checks if the download was successful by looking for a "#" at the
beginning of the file. This is now broken. So the real issue
here is that osmupdate calls wget but instead of checking for
exit code, stat'ing the file and looking for size it simply
checks for the "#" at offset 0 of the file.

So this is a larger undertaking to fix this with a proper fix
i would be happy with.

But i'd rather not touch osmupdate/osmconvert without major
refactoring the code for coding style issues, readability
and stuff.

And for osmconvert a lot of people have switched to osmium 
already. The only thing IIRC missing in osmium is downloading
and merging the change files and automatically apply those
merged changes onto a pbf.

Florian Lohoff                                                     f at zz.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.openstreetmap.org/pipermail/dev/attachments/20210222/eee09afe/attachment.sig>

More information about the dev mailing list