[OSM-dev] Want to contribute to OpenStreetMap in GSoC 2023

Sun Feb 5 17:05:44 UTC 2023

Hi Veenit,

thanks for considerung contributing to Valhalla, always welcome!

Sure, we can guide you a bit on your first issue. Best to bump us on the one you choose to work on.

Regarding docker: I guess you're on Apple Silicon and tried to build for "--platform linux/arm64"? Then it should build bindings for arm64 which of course leads to a different name for the Python bindings than python_valhalla.cpython-310-x86_64-linux-gnu.so. So a quick fix is probably to run the amd64 image directly from Dockerhub (might not work though?). In any case, this is rather a bug, we'd like to support arm64 images. Hopefully they'll eventually become really relevant outside of Apple at some point.

Regardless, docker is maybe not so important if you want to develop. There's even docs how to build for Apple Silicon natively: https://valhalla.github.io/valhalla/building/#building-from-source-macos.

And 2 more slight decorum things:

- best to keep project-specific stuff in the Github project, either issues (e.g. this one) or Discussions
- please avoid screenshots of code (at least on Github, drives me personally crazy);)

All the best
Nils

On 05.02.23 15:29, Veenit Kumar wrote:

> Hi everyone,
>
> I am starting to contribute to Valhalla. I am going through the project structure and I have seen a couple of good first issues and I like to jump in [1].
>
> I am facing this issue while installing using the Docker image.
>
> Any help or lead would be appreciated.
>
> vee_nits123 at Veenits-MacBook-Air valhalla % docker build .
> [+] Building 394.0s (29/32)
> => [internal] load build definition from Dockerfile 0.1s
> => => transferring dockerfile: 3.25kB 0.1s
> => [internal] load .dockerignore 0.0s
> => => transferring context: 35B 0.0s
> => [internal] load metadata for docker.io/library/ubuntu:22.04 6.9s
> => CACHED [runner 1/4] FROM docker.io/library/ubuntu:22.04 at sha256:9a0bdde4188b896a372804be2384015e90e3f84906 0.0s
> => [internal] load build context 0.1s
> => => transferring context: 74.56kB 0.1s
> => CACHED [builder 2/25] WORKDIR /usr/local/src/valhalla 0.0s
> => CACHED [builder 3/25] COPY ./scripts/install-linux-deps.sh /usr/local/src/valhalla/scripts/install-linux 0.0s
> => CACHED [builder 4/25] RUN bash /usr/local/src/valhalla/scripts/install-linux-deps.sh 0.0s
> => CACHED [builder 5/25] ADD . /usr/local/src/valhalla 0.0s
> => CACHED [builder 6/25] RUN ls 0.0s
> => CACHED [builder 7/25] RUN git submodule sync && git submodule update --init --recursive 0.0s
> => CACHED [builder 8/25] RUN rm -rf build && mkdir build 0.0s
> => CACHED [builder 9/25] RUN pip install --upgrade conan 0.0s
> => CACHED [builder 10/25] WORKDIR /usr/local/src/valhalla/build 0.0s
> => CACHED [builder 11/25] RUN cmake .. -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_C_COMPILER=gcc 0.0s
> => [builder 12/25] RUN cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_OSX_ARCHITECTURES="x86_64" 2.4s
> => [builder 13/25] RUN make all -j${CONCURRENCY:-$(nproc)} 373.5s
> => [builder 14/25] RUN make install 4.5s
> => [builder 15/25] WORKDIR /usr/local/src 0.0s
> => [builder 16/25] RUN cd valhalla && echo "https://github.com/valhalla/valhalla/tree/$(git rev-parse HEAD)" 0.2s
> => [builder 17/25] RUN for f in valhalla/locales/*.json; do cat ${f} | python3 -c 'import sys; import json; 0.7s
> => [builder 18/25] RUN rm -rf valhalla 0.8s
> => [builder 19/25] WORKDIR /usr/local/bin 0.0s
> => [builder 20/25] RUN for f in valhalla_*; do objcopy --only-keep-debug $f $f.debug; done 0.5s
> => [builder 21/25] RUN tar -cvf valhalla.debug.tar valhalla_*.debug && gzip -9 valhalla.debug.tar 2.9s
> => [builder 22/25] RUN rm -f valhalla_*.debug 0.1s
> => [builder 23/25] RUN strip --strip-debug --strip-unneeded valhalla_* || true 0.6s
> => [builder 24/25] RUN strip /usr/local/lib/libvalhalla.a 0.5s
> => ERROR [builder 25/25] RUN strip /usr/lib/python3/dist-packages/valhalla/python_valhalla.cpython-310-x86_6 0.2s
> ------
>> [builder 25/25] RUN strip /usr/lib/python3/dist-packages/valhalla/python_valhalla.cpython-310-x86_64-linux-gnu.so:
> #29 0.145 strip: '/usr/lib/python3/dist-packages/valhalla/python_valhalla.cpython-310-x86_64-linux-gnu.so': No such file
> ------
> executor failed running [/bin/sh -c strip /usr/lib/python3/dist-packages/valhalla/python_valhalla.cpython-310-x86_64-linux-gnu.so]: exit code: 1
> vee_nits123 at Veenits-MacBook-Air valhalla %
>
> [1] https://github.com/valhalla/valhalla/labels/good%20first%20issue
>
> Thanks!
>
> Veenit

--

Nils Nolde
Developer / Co-Founder
Website: https://gis-ops.com
Email: nils at gis-ops.com
Phone: [+49 (0)178 5161 595](tel +491785161595)
[Mühlenstraße 8 a, 14167 Berlin](https://valhalla.openstreetmap.de/directions?profile=bicycle&wps=13.2618285%2C52.4299717)
[social-icon-github](https://github.com/nilsnolde)
[social-icon-linkedin](https://www.linkedin.com/in/nils-nolde-geophox/)
mailto:nils at gis-ops.com
[social-icon-github](https://twitter.com/gis_ops)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/dev/attachments/20230205/98eab270/attachment-0001.htm>