[Imports] [Talk-us] GNIS tag removal proposal

Jason Remillard remillard.jason at gmail.com
Wed Sep 11 14:07:12 UTC 2013


Hi Bryce,

If you really want to be sure nobody gets confused by some of the
"extra" tags in the drop tags, you could run an automated edit project
to remove them. I am not 100% sure about this, but putting something
in the JOSM drop list is 50x less work than running an automated edit
project over the entire US, so it means that the tags are a problem,
we would like them gone, but the small list of people that tend of do
these kind of projects don't want to spend the time to kill them
wholesale....

Thanks
Jason






On Wed, Sep 11, 2013 at 4:00 AM, Bryce Nesbitt <bryce2 at obviously.com> wrote:
> Here's a patch to JOSM to warn the human editor about tags that are about to
> disappear.  What do you think?
>
>
> --- src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java
> (revision 6232)
> +++ src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java
> (working copy)
> @@ -280,6 +276,26 @@
>
> propertyTable.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);
>          propertyTable.getTableHeader().setReorderingAllowed(false);
>
> +        // Style the key column
> +        propertyTable.getColumnModel().getColumn(0).setCellRenderer(new
> DefaultTableCellRenderer(){
> +            @Override public Component getTableCellRendererComponent(JTable
> table, Object value,
> +
> boolean isSelected, boolean hasFocus, int row, int column) {
> +                Component cc = super.getTableCellRendererComponent(table,
> value, isSelected, false, row, column);
> +                if (value == null)
> +                    return this;
> +                String myvalue = (String)value;
> +                if (OsmPrimitive.getDiscardableKeys().contains(myvalue) ) {
> +                    cc.setFont(cc.getFont().deriveFont(Font.ITALIC));
> +                    cc.setBackground(Color.RED);
> +                } else {
> +                    cc.setFont(cc.getFont().deriveFont(Font.PLAIN));
> +                    cc.setBackground(Color.WHITE);
> +                }
> +                return cc;
> +            }
> +        });
> +
> +        // Style the value column
>          propertyTable.getColumnModel().getColumn(1).setCellRenderer(new
> DefaultTableCellRenderer(){
>              @Override public Component getTableCellRendererComponent(JTable
> table, Object value,
>                      boolean isSelected, boolean hasFocus, int row, int
> column) {
>
>
> _______________________________________________
> Imports mailing list
> Imports at openstreetmap.org
> https://lists.openstreetmap.org/listinfo/imports
>



More information about the Imports mailing list