[josm-dev] Jumbo Patch

[Dave Hansen]

On Sun, 2007-12-16 at 22:14 +0100, Gabriel Ebner wrote:
> I think the ReplaceSubObjectCommand might be a bit too general.  1) It doesn't
> support multiple uses of the same node in a way (think roundabouts).  You
> can't even add a node twice (you explicitly prohibited this).  2) You can't
> add nodes other than at the end of the way.  3) It isn't clear how to extend
> it to support relations (how to change/specify roles?).
> 
> Wouldn't it make more sense to have an AddNodeToWayCommand, a
> RemoveNodeFromWayCommand, and a ReplaceNodeInWayCommand, taking indices
> instead of nodes?  This would get us rid of the highly complex Way.replace
> logic, and we'd be able to properly support duplicate nodes, while making it
> possible to better guard against erroneous requests. 

That seems reasonable to me.  I'll give it a go.

-- Dave