[josm-dev] Jumbo Patch v3 (or so)

[Dave Hansen]

On Mon, 2007-12-17 at 16:23 +0100, Gabriel Ebner wrote:
> On Mon, Dec 17, 2007 at 12:15:01AM -0800, Dave Hansen wrote:
> > So, I actually implemented the read-only view of the Way.nodes list.
> > Works like a charm!  (Instead of blathering about it in an email on
> > proper encapsulation :P)
> > 
> > http://dev.openstreetmap.org/~daveh/josm/003/
> > 
> > This removes a pretty serious chunk of the original diff.  It shrunk by
> > at least 10k or so, and I can probably do even more pruning.
> 
> Maybe I didn't get my point across clearly, but I think that there are
> concrete problems introduced by the very design of adding the reverse-lookup
> table into the nodes:
...

Thanks for describing all that.  I was just trying to post something
incremental, and I'm sure I won't be able to address all of your
comments for a while. :)

In any case, all of the stuff that you describe here sounds like bugs in
my implementation more than fundamental limitation.  I could be wrong,
but I'm unconvinced that there are fundamental problems with
reverse-lookup.  We'll see how painful it is to keep my patch
synchronized.  That may change my mind.

> > Gabriel, I also did some serious work to DuplicatedNodes.  I took your
> > ideas to heart, and implemented something that actually creates a map
> > from LatLon->[Types]->[Nodes].  So, it's a hash of LatLons, which
> > indexes into a list of the types of nodes at that LatLon, then the
> > nodes.
> 
> Okay, that looks better now.  Though we could probably still save some sixty
> lines by calling MergeNodes.mergeNodes(sel, nodes) in fixError instead of
> doing the merging ourselves.

I'll look at that next.

-- Dave